Bug #19608
FE - React - Apply fieldset for all form
| Status: | Closed | Start date: | 29 January 2024 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | 30 January 2024 | |
| Assignee: | chok yee fan | % Done: | 0% | |
| Category: | - | Spent time: | - | |
| Target version: | - |
Description
apply fieldset for all form.
refer the attachment
History
#1 Updated by chok yee fan 9 months ago
- Due date set to 30 January 2024
#2 Updated by Hazimi Muhammad 9 months ago
- Status changed from New to Resolved
- Assignee changed from Hazimi Muhammad to chok yee fan
Hazimi - Bug #19608-FE - React - Apply fieldset for all form
~/Documents/React/mleb-iam/cc_iam/src/pages
business-constitution
BusinessConstitutionForm.tsx
country
CountryForm.tsx
email-config
EmailConfigForm.tsx
mleb-function
MlebFunctionForm.tsx
organization-profile/department-tab
DepartmentForm.tsx
security-policy
SecurityPolicyForm.tsx
user-category
UserCategoryForm.tsx
user-role
UserRoleForm.tsx
UserRoleTabs.tsx
#3 Updated by chok yee fan 9 months ago
- File Screenshot 2024-01-30 at 2.50.20 PM.png added
- File Screenshot 2024-01-30 at 2.57.07 PM.png added
- File Screenshot 2024-01-30 at 3.14.52 PM.png added
- Status changed from Resolved to Feedback
- Assignee changed from chok yee fan to Hazimi Muhammad
extremely careless
OrganisationProfileForm not put it in
DepartmentForm must under the <form> if not have to add in the <form>
UserRoleForm.tsx not put it in
#4 Updated by Hazimi Muhammad 9 months ago
- File WhatsApp Image 2024-01-30 at 5.00.10 PM.jpeg added
- File WhatsApp Image 2024-01-30 at 5.00.10 PM.jpeg added
- Assignee changed from Hazimi Muhammad to chok yee fan
My Bad.The reason i not put inside the FORM page is form module don't have the updateActionRes so i put it in the TAB
Hazimi - Bug #19608-IAM > FE - React - Apply fieldset for all form
~/Documents/React/mleb-iam/cc_iam/src/pages/organization-profile
department-tab
DepartmentForm.tsx
organisation-profile-tab
OrganisationProfileForm.tsx
OrganisationProfileTabs.tsx
#5 Updated by chok yee fan 9 months ago
- Assignee changed from chok yee fan to Amirul Umar Pandai
Check the developer put the code is correct or not. since is touching ur module
#6 Updated by Amirul Umar Pandai 9 months ago
- Assignee changed from Amirul Umar Pandai to Hazimi Muhammad
Hazimi came to me asking how he should modify my modules, since they're the few modules that contain tabs instead of regular form pages. I was the one who advised him how to do my modules, apologies. After examining this Redmine further, I decided to put updateActionRes into the ...Form.tsx pages themselves, omitting the request object and using fixedCacheKey to persist the data across the tabs.
fieldset for Org Profile, Department, User Role
#7 Updated by Hazimi Muhammad 9 months ago
- Assignee changed from Hazimi Muhammad to chok yee fan
#8 Updated by Hazimi Muhammad 9 months ago
-Go to any module that has Form > Inspect > Network > No throttling > slow 3G > fill the form and click save.
Implement for all form page :
BusinessConstitutionForm.tsx
CountryForm.tsx
EmailConfigForm.tsx
MlebFunctionForm.tsx
DepartmentForm.tsx
SecurityPolicyForm.tsx
UserCategoryForm.tsx
UserRoleForm.tsx
DepartmentForm.tsx
OrganisationProfileForm.tsx
UserRoleTabs.tsx
#9 Updated by chok yee fan 9 months ago
- Status changed from Feedback to Closed
just adding the fields due to different code pattern/styling cause mistake and longest time development and debugs