Bug #19106

FE - React - Org profile view cancel wrong behaviour

Added by chok yee fan 11 months ago. Updated 9 months ago.

Status:ClosedStart date:07 December 2023
Priority:NormalDue date:
Assignee:chok yee fan% Done:

100%

Category:-Spent time:-
Target version:-

Description

issue
----
org profile search -> view record -> modify -> cancel -> prompt ok or cancel -> cancel -> navigate back to search.

expected
----
org profile search -> view record -> modify -> cancel -> prompt ok or cancel -> cancel -> stay.

Screenshot 2023-12-18 at 11.26.08 AM.png (324 KB) chok yee fan, 18 December 2023 11:26 AM

Screenshot 2024-01-04 at 5.50.27 PM.png - viewRecord (427 KB) chok yee fan, 04 January 2024 05:50 PM

Screenshot 2024-01-08 at 2.51.56 PM.png (501 KB) chok yee fan, 08 January 2024 02:52 PM

History

#1 Updated by Amirul Umar Pandai 11 months ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Cancel behaviour is committed now, please check.

#2 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

- re-populate form on language change (#19075, organisation profile + user role page only)
- fix org profile view cancel behaviour (#19106)

https://dev.silverlakemobility.com/gitlab/mleb-solution-domain/smesd100/mleb-iam/-/commit/966508fdc788fb2f6eef2cfaaed8b11f7a9a0854

#3 Updated by chok yee fan 10 months ago

  • Status changed from Resolved to Assigned
  • Assignee changed from chok yee fan to Amirul Umar Pandai

issue still the same, no fix at all.

issue
----
org profile search -> view record -> modify -> cancel -> prompt ok or cancel -> click cancel -> navigate back to search.

expected
----
org profile search -> view record -> modify -> cancel -> prompt ok or cancel -> click cancel -> stay.

#4 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

#5 Updated by chok yee fan 10 months ago

nothing happen when click Modify button

#6 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

- fix org profile modify button does nothing
- move usePrompt hook to own file
- re-organise org profile + user role code

https://dev.silverlakemobility.com/gitlab/mleb-solution-domain/smesd100/mleb-iam/-/commit/b3c05da00efe3b92cf2c23f8f4134dfdcd251bb2

#7 Updated by chok yee fan 10 months ago

  • Assignee changed from chok yee fan to Amirul Umar Pandai

use <FormProvider passing hookForm into child.
refer UserProfileTab

#8 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

- delete content-tab + hq-tab from org profile
- put FormContainer for org profile tab
- checkbox tree column filter + collapsed by default

https://dev.silverlakemobility.com/gitlab/mleb-solution-domain/smesd100/mleb-iam/-/commit/3583dc9b0f14fbb88991b43783e02576c5d3c4a1

#9 Updated by chok yee fan 10 months ago

  • Assignee changed from chok yee fan to Amirul Umar Pandai

issue
------
no function when click modify button

expected
------
should function when click modify button

#10 Updated by chok yee fan 10 months ago

issue
------
Search org profile -> click link from table -> view org profile
1. not using /api/organisationWs/dataEntryForm to populate the dropdown value and other info.
2. call multiple times on searchForm

expected
------
1. use /api/organisationWs/dataEntryForm to populate the dropdown value and other info.
2. should not call multiple times on searchForm

we standard to use /dataEntryForm to populate dropdown value instead of /viewAction

#11 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

Extra call to searchForm was actually to departmentWs by department tab together with all organisation profile tabs, all without clicking the tab. This is now changed to only mount when clicking department tab.

Call dataEntryForm on modify + prevent multiple call to searchForm on navigate:
- Organisation Profile
- Department (Tab)
- User Role

https://dev.silverlakemobility.com/gitlab/mleb-solution-domain/smesd100/mleb-iam/-/commit/e6230171c29472b2ac21e629df2cb0114e42c23c

#12 Updated by chok yee fan 10 months ago

issue
------
Search org profile -> click link from table -> view org profile
1. not using /api/organisationWs/dataEntryForm to populate the dropdown value and other info.

expected
------
1. use /api/organisationWs/dataEntryForm to populate the dropdown value and other info.

#13 Updated by Amirul Umar Pandai 10 months ago

  • Assignee changed from Amirul Umar Pandai to chok yee fan

Trigger dataEntryForm for all form modes:
- Organisation Profile
- Department (Tab)
- User Role

https://dev.silverlakemobility.com/gitlab/mleb-solution-domain/smesd100/mleb-iam/-/commit/d2a1bf39cb56770bc5736e651bd1637236627a98

#14 Updated by chok yee fan 9 months ago

  • Status changed from Feedback to Closed

tested ok

Also available in: Atom PDF