Bug #14889

MB & IB - transaction-history, list, receipt, summary convert to ngrx data

Added by chok yee fan almost 2 years ago. Updated about 1 year ago.

Status:ClosedStart date:25 November 2022
Priority:NormalDue date:
Assignee:Hoo Dextor% Done:

0%

Category:-Spent time:-
Target version:-
Phase:R1 Branch Code:showroom-proj-base-i5

Description

Issue
------
Currently not using ngrx data.

Expected
------
Use ngrx data.

Location of files
IB
apps/web-showroom/src/app/transaction-history/transaction-history.ts

MB
apps/showroom-mb/src/app/transaction-history/transaction-history.ts

Receipt.png (19.8 KB) Pui Shan Lee, 27 December 2022 09:27 AM

History

#1 Updated by chok yee fan almost 2 years ago

  • Subject changed from MB & IB - Transaction History convert to ngrx data to MB & IB - transaction-history, list, receipt, summary convert to ngrx data

#2 Updated by Axel Sidharta almost 2 years ago

  • Status changed from New to Resolved
  • Assignee changed from Axel Sidharta to Hoo Dextor

r220543 | axel | 2022-12-21 02:22:42 WIB
Changed paths:
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/transaction-history-entity-metadata.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/transaction-history-receipt/transaction-history-receipt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/transaction-history/transaction-history.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history/transaction-history.module.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/perform-tran-hist-search-entity.service.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/request-mobile-transaction-history-entity.service.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history/transaction-history.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/retrieve-trans-history-details-entity.service.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/retrieve-ui-ux-receipt-entity.service.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history-summary/transaction-history-summary.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history-receipt/transaction-history-receipt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/transaction-history-receipt/transaction-history-receipt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history-summary/transaction-history-summary.module.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/retrieve-gp-request-trans-details-entity.service.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/transaction-history-receipt/transaction-history-receipt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/index.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/transaction-history/data-access/src/lib/shared-transaction-history-data-access.module.ts

Bug #14889 transaction history change to ngrx
----------------------------------------------------------------------------

#3 Updated by Pui Shan Lee almost 2 years ago

  • File Receipt.png added
  • Status changed from Resolved to Feedback

(IB) Issue:
History → no options in dropdown menu

Expected:
History → Options will show

Possible solution:
in transaction-history.html (web)
line 36:

<nz-option
*ngFor="let trans of transactionTypeList; let i = index"
[nzValue]="trans"
[nzLabel]="trans.transactionTypeDescription"
</nz-option>

in transaction-history.ts
replace this.requestMobileTransactionHistoryEntityService.entities$.pipe( with the lines of code below

this.requestMobileTransactionHistoryEntityService.entities$.pipe(
takeUntil(this.unsubscribe$),
filter((res) => res && res.length > 0),
map((res) => res[0])
).subscribe((res: any) => {
if (this.commonService.isSuccessResponse(res)) {
console.log(res?.body)
let data = res?.body;
if (data.pexReqTransList) {
this.store.dispatch(
new RouterActions.Go({
path: 'TransactionHistoryListPage',
query: {
response: data,
title: this.transactionType.transactionTypeDescription,
},
})
);
}
if (this.statusList.length <= 0) {
this.statusList = data.statusList;
}
if (this.transactionTypeList.length <= 0) {
this.transactionTypeList = data.transactionTypeList;
}
this.cdr.detectChanges();
} else {
this.store.dispatch(
CommonActions.CommonFailed({ payload: res.error })
);
}
});

then, add a line after the curly bracket of let param

this.commonService.showLoading();

#4 Updated by Pui Shan Lee almost 2 years ago

  • Assignee changed from Hoo Dextor to chok yee fan

#5 Updated by Wui Ling Chai almost 2 years ago

MB Issue:
An error message appeared when "Search" button is clicked

Steps:
1. Login
2. Side menu -> History
3. Transaction History
4. Select “Request Mobile (Send)” as the first input which is Transaction Type
5. Randomly select “status”
6. Click “Search”
7. Error msg pop up [Status Text: no res]

Expected outcome:
Able to display transaction history

Possible Solution: -

#6 Updated by chok yee fan almost 2 years ago

  • Assignee changed from chok yee fan to Axel Sidharta

please refer the previous comment fix according

#7 Updated by chok yee fan almost 2 years ago

  • Assignee changed from Axel Sidharta to Wui Ling Chai

Wui Ling Chai wrote:

MB Issue:
An error message appeared when "Search" button is clicked

Steps:
1. Login
2. Side menu -> History
3. Transaction History
4. Select “Request Mobile (Send)” as the first input which is Transaction Type
5. Randomly select “status”
6. Click “Search”
7. Error msg pop up [Status Text: no res]

Expected outcome:
Able to display transaction history

Possible Solution: -

look like axel resolve, u try

#8 Updated by Wui Ling Chai almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from Wui Ling Chai to Hoo Dextor

#9 Updated by Pui Shan Lee almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Hoo Dextor to chok yee fan

(IB) Issue:

1. Select desired options.
2. Click 'Search'
-- No result showed up.

Expected:

The transaction history shows up after clicking the 'search' button.

#10 Updated by Pui Shan Lee almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from chok yee fan to Hoo Dextor

r220865 | leepsh | 2023-01-09 15:18:11 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/transaction-history/transaction-history.ts

Pui Shan: (IB) Retrieved transaction history successfully
----------------------------------------------------------------------------

#11 Updated by Hoo Dextor about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF