Bug #14915

IB&MB - telegraphic-transfer - Convert to ngrx data

Added by chok yee fan almost 2 years ago. Updated about 1 year ago.

Status:ClosedStart date:25 November 2022
Priority:NormalDue date:
Assignee:Hoo Dextor% Done:

0%

Category:-Spent time:-
Target version:-
Phase:R1 Branch Code:showroom-proj-base-i5

Description

Issue
------
Currently not using ngrx data.

Expected
------
Use ngrx data.

History

#1 Updated by Wong Mun Fung almost 2 years ago

  • Status changed from New to In Progress

#2 Updated by Wong Mun Fung almost 2 years ago

r220215 | wongmf | 2022-12-07 09:36:16 MYT
Changed paths:
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/telegraphic-transfer-entity-metadata.ts
A /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/telegraphic-transfer-step-entity.service.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/index.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/shared-telegraphic-transfer-data-access.module.ts

mun fung : Bug #14915 IB&MB - telegraphic-transfer - Convert to ngrx data (part 1)
----------------------------------------------------------------------------

r220218 | wongmf | 2022-12-07 10:43:50 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/home/side-menu.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/home/side-menu.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/transfer-details-tt/transfer-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts

mun fung : Bug #14915 IB&MB - telegraphic-transfer - Convert to ngrx data (mainly showroom-mb)
----------------------------------------------------------------------------

r220221 | wongmf | 2022-12-07 10:48:40 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.html
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.html
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.html
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.html

mun fung : Bug #14915 IB&MB - telegraphic-transfer - Convert to ngrx data (mainly webshowroom)
----------------------------------------------------------------------------

#3 Updated by Wong Mun Fung almost 2 years ago

r220230 | wongmf | 2022-12-07 11:31:19 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/shared-telegraphic-transfer-data-access.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/transfer-details-tt/transfer-details-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.module.ts

mun fung : Bug #14915 IB&MB - telegraphic-transfer - Convert to ngrx data (remove normal ngrx effects and reducers registration in module)
----------------------------------------------------------------------------

#4 Updated by Wong Mun Fung almost 2 years ago

r220231 | wongmf | 2022-12-07 11:46:38 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts

mun fung : Bug #14915 IB&MB - telegraphic-transfer - Convert to ngrx data (remove validaton for succcess response code in subscribe and use isSuccessResponse from common service instead)
----------------------------------------------------------------------------

#5 Updated by Wong Mun Fung almost 2 years ago

  • Status changed from In Progress to Resolved
  • Assignee changed from Wong Mun Fung to Hoo Dextor

r220239 | wongmf | 2022-12-07 15:19:48 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/telegraphic-transfer-step-entity.service.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/shared-telegraphic-transfer-data-access.module.ts

mun fung : change services naming to data service (telegraphic transfer)
----------------------------------------------------------------------------
r220238 | wongmf | 2022-12-07 15:04:35 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/telegraphic-transfer-entity-metadata.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/shared-telegraphic-transfer-data-access.module.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/libs/shared/telegraphic-transfer/data-access/src/lib/telegraphic-transfer-step-entity.service.ts

mun fung : change Medatadata naming to Metadata for telegraphic transfer
----------------------------------------------------------------------------

#6 Updated by Wong Mun Fung almost 2 years ago

r220531 | wongmf | 2022-12-20 16:45:02 MYT
Changed paths:
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/transfer-details-tt/transfer-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /HLF/Source/SMEHLF900/branches/hlf-dfe-R1S1/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts

mun fung : add skipUntil(timer(0) to error$ sub for telegraphic transfer
----------------------------------------------------------------------------

r220532 | wongmf | 2022-12-20 16:46:26 MYT
Changed paths:
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/country-selection-tt/country-selection-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/receipt-details-tt/receipt-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/confirm-details-tt/confirm-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/web-showroom/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/transfer-details-tt/transfer-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/purpose-details-tt/purpose-details-tt.ts
M /Showroom/02_BaseProjects/BASE900/trunk/showroom-proj-base-i5/showroom-nx/apps/showroom-mb/src/app/telegraphic-transfer/recipient-details-tt/recipient-details-tt.ts

mun fung : add skipUntil(timer(0) to error$ sub for telegraphic transfer
----------------------------------------------------------------------------

#7 Updated by Wui Ling Chai almost 2 years ago

  • Status changed from Resolved to Feedback
  • Assignee changed from Hoo Dextor to chok yee fan

MB Issue:
At the confirm details page, when the "Proceed" button is clicked, it will appear an error message [M006]

Steps:
1. Login
2. Side menu -> Transfer -> Telegraphic Transfer
3. Fill in all the blanks till the Foreign Telegraphic Transfer page and click on the "Proceed" button
4. Error msg pop up [M006]

Expected outcome:
Able to proceed to other page after clicking on the "Proceed" button

Possible Solution: -

#8 Updated by Pui Shan Lee almost 2 years ago

(IB) Issue:

Transfer → telegraphic transfer → Choose China → error (MIB.0000015) → Press ‘ok’ → can proceed

Expected:

After error (MIB.0000015), Error (no res) will prompt and cannot process

#9 Updated by chok yee fan almost 2 years ago

  • Assignee changed from chok yee fan to Wong Mun Fung

#10 Updated by chok yee fan almost 2 years ago

Wui Ling Chai wrote:

MB Issue:
At the confirm details page, when the "Proceed" button is clicked, it will appear an error message [M006]

Steps:
1. Login
2. Side menu -> Transfer -> Telegraphic Transfer
3. Fill in all the blanks till the Foreign Telegraphic Transfer page and click on the "Proceed" button
4. Error msg pop up [M006]

Expected outcome:
Able to proceed to other page after clicking on the "Proceed" button

Possible Solution: -

tested the app behave the same, will ignore the error

#11 Updated by Pui Shan Lee almost 2 years ago

  • Assignee changed from Wong Mun Fung to chok yee fan

refer to https://dev.silverlakemobility.com/redmine/issues/14915#note-8

issue solved, same as the served website

#12 Updated by Wui Ling Chai almost 2 years ago

  • Status changed from Feedback to Resolved
  • Assignee changed from chok yee fan to Hoo Dextor

#13 Updated by Hoo Dextor about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF